Skip to content

Conversation

@MSBarbieri
Copy link

i needed a way to ignore two projects in my workspaces.
one specific by the dirName and another by a subdir.

info: i'm not an english speaker, so please check if i write something wrong

@GnikDroy
Copy link
Owner

GnikDroy commented Dec 11, 2022

I took a cursory look at the PR. And everything looks great. Well done.

Although, I have a few questions since this breaks the current API (workspaces.json format is not same).

Instead of ignore_patterns and ignore_dirs, perhaps we can let users configure a filter function. This will allow more power at the cost of slightly difficult configuration. Additionally, this won't break the current API. But the cost is we can't specify ignore_patterns and ignore_dirs dynamically through the json file. What are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants