Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sk + cz + (some) en + de bible versions #13

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

typekpb
Copy link
Contributor

@typekpb typekpb commented Dec 29, 2024

No description provided.

@Glowstudent777
Copy link
Owner

I'll look through this and test it, it looks pretty good at a glance though. Would you mind making a pr on the other project for the versions file?

@typekpb
Copy link
Contributor Author

typekpb commented Dec 29, 2024

@Glowstudent777 what other project are you referring to?

@Glowstudent777
Copy link
Owner

I have an NPM package using mostly the same code base.

https://github.com/Glowstudent777/YouVersion-API-NPM

@typekpb
Copy link
Contributor Author

typekpb commented Dec 30, 2024

well, if that is the case, would not be the proper solution simply reuse of the referred npm module as part of this project? otherwise maintenance of the duplicate codebase might be rather painful.

@Glowstudent777
Copy link
Owner

I've thought about making a separate repository for the versions and the main functions and have it be a dependency to these projects. It might be something I get around to today or tomorrow now that it's becoming more of a hassle to copy between the two.

@Glowstudent777
Copy link
Owner

I'm merging your two pull requests but they're going to be pretty much pulled into the new core repo.

@Glowstudent777 Glowstudent777 merged commit 98eced0 into Glowstudent777:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants