Skip to content

Conversation

@vegaale313
Copy link

Overview

This PR introduces a placeholder file (TODOEventHooks.java) to begin documenting and organizing missing event trigger logic within Glowstone’s Bukkit-compatible API. Based on issue #922, several gameplay interactions currently do not fire the expected events (e.g., PlayerMoveEvent, InventoryClickEvent), causing incompatibility with plugins that rely on these hooks.

Motivation

The goal of this commit is to establish a central point to track these gaps and gradually improve coverage and consistency with Bukkit behavior. This file will act as a staging ground for identifying missing hooks and associating them with relevant gameplay flows before full implementations are made.

Next Steps

  • Map in-game actions to expected Bukkit events
  • Locate appropriate injection points in the event pipeline
  • Gradually implement and test new hooks

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2025

CLA assistant check
All committers have signed the CLA.

@mastercoms
Copy link
Member

mastercoms commented Apr 23, 2025

Hi, thanks for your contribution and writeup! I'm open to this idea, are we thinking this class will be constructed at those entry points so we can find usages later on and figure out how to integrate the event? I feel like most of the workload is associated with that locating places to put the events, and actually creating and using an event has been pretty straightforward. So maybe you're proposing to do planning in the code file structure? In my opinion it's probably better documented in the issue you linked, to post planning regarding where an event generally should be going. I'm not entirely sure if I understand entirely so I would appreciate some more clarification and apologize for not getting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants