-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Java 8 too on Azure Pipelines #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good - RE code coverage, do we need to be running coverage on anything but the latest JDK version? Can we skip it on the JDK8 build? It doesn't seem like we really need to be running it twice.
What do you think?
Coverage is probably identical on both.
Turned off JDK8 coverage. |
…toneMC/Glowstone into azurePipelinesMultiVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work - resolve this review, and I'll be happy to merge this.
It's a shame we couldn't do this using the version matrix, but that's okay. This should work nicely.
Since Azure Pipelines allows up to 10 concurrent jobs, we can easily afford to run a second one per push, and it can help us ensure we're not breaking compatibility with JDK 8 (which I think some plugins still require). This PR adds a second job on JDK 8, and renames the jars from that second job; I'm not sure why there's only one coverage report.