Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Java 8 too on Azure Pipelines #1033

Merged
merged 15 commits into from
Mar 25, 2019
Merged

Test Java 8 too on Azure Pipelines #1033

merged 15 commits into from
Mar 25, 2019

Conversation

Pr0methean
Copy link
Contributor

Since Azure Pipelines allows up to 10 concurrent jobs, we can easily afford to run a second one per push, and it can help us ensure we're not breaking compatibility with JDK 8 (which I think some plugins still require). This PR adds a second job on JDK 8, and renames the jars from that second job; I'm not sure why there's only one coverage report.

@Pr0methean Pr0methean requested a review from gdude2002 March 12, 2019 22:58
@Pr0methean Pr0methean requested a review from gdude2002 March 13, 2019 01:24
Copy link
Contributor

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good - RE code coverage, do we need to be running coverage on anything but the latest JDK version? Can we skip it on the JDK8 build? It doesn't seem like we really need to be running it twice.

What do you think?

Coverage is probably identical on both.
@Pr0methean
Copy link
Contributor Author

Turned off JDK8 coverage.

Copy link
Contributor

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - resolve this review, and I'll be happy to merge this.

It's a shame we couldn't do this using the version matrix, but that's okay. This should work nicely.

@gdude2002 gdude2002 merged commit d617350 into dev Mar 25, 2019
@gdude2002 gdude2002 deleted the azurePipelinesMultiVersion branch March 25, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants