This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
Release v0.3.0 #26
Merged
Release v0.3.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
November 22, 2018 02:26
…ients now we can use build() - with possibly throws or buildAsync() - which returns Mono response
- adding missing javadoc in #checkRequiredScope() - adding #handleScopeMissng() to handling ScopeIsMissingException after scopes checks - docing #handleScopeMissng() aswell
- adds CursorList for cursors - size will get default from #getData().size();
- Gradle -> 5.0
- net.ltgt.apt -> 0.19
- reactor-bom -> Californium-SR3
- okhttp3 -> 3.12.0
- guava -> 27.0.1-jre
- removed `enableFeaturePreview('STABLE_PUBLISHING')`
- request body is now a Builders - EmoteSets now is a list of Emote
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| public class VideoService extends AbstractHttpService { | ||
| public VideoService(GlitchKraken rest) { | ||
| super(rest.getClient(), rest.getHttpClient()); | ||
| } | ||
|
|
||
| public Mono<Video> getVideo(Long id) { | ||
| return exchange(get(String.format("/videos/%s", id), Video.class)).toMono(); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "/videos/%s" 3 times.
| public Mono<AuthorizedUser> getUsers(Credential credential) { | ||
| return Mono.just(checkRequiredScope(credential.getScopes(), Scope.USER_READ)).flatMap(b -> { | ||
| if (b) { | ||
| return exchange(get("/user", AuthorizedUser.class).header("Authorization", "OAuth " + credential.getAccessToken())).toMono(); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "Authorization" 5 times.
| } | ||
|
|
||
| public Mono<ChannelFollow> getFollow(User user, Channel channel) { | ||
| return exchange(get(String.format("/users/%s/follows/channels/%s", user.getId(), channel.getId()), ChannelFollow.class)).toMono() |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "/users/%s/follows/channels/%s" 3 times.
| public Mono<AuthorizedUser> getUsers(Credential credential) { | ||
| return Mono.just(checkRequiredScope(credential.getScopes(), Scope.USER_READ)).flatMap(b -> { | ||
| if (b) { | ||
| return exchange(get("/user", AuthorizedUser.class).header("Authorization", "OAuth " + credential.getAccessToken())).toMono(); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "OAuth " 5 times.
| return Mono.just(checkRequiredScope(credential.getScopes(), Scope.CHANNEL_READ)).flatMap(b -> { | ||
| if (b) { | ||
| return exchange(get("/channel", AuthorizedChannel.class) | ||
| .header("Authorization", "OAuth " + credential.getAccessToken())).toMono(); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "Authorization" 7 times.
|
Code Climate has analyzed commit b65befb and detected 32 issues on this pull request. Here's the issue category breakdown:
Note: there are 7 critical issues. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.