Dashboard : Device value on 2 lines #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrovato
force-pushed
the
atrovato/issue925
branch
from
def354e to
2557d18
Compare
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 462 462
Lines 6133 6133
=======================================
Hits 5779 5779
Misses 354 354 Continue to review full report at Codecov.
|
|
So how does it looks like when the text is long ? |
Pierre-Gilles
requested changes
Nov 9, 2020
| @@ -23,7 +24,7 @@ const SensorDeviceType = ({ children, ...props }) => ( | |||
| </td> | |||
| <td>{props.deviceFeature.name}</td> | |||
| {SPECIAL_SENSORS.indexOf(props.deviceFeature.category) === -1 && ( | |||
| <td class="text-right"> | |||
| <td class={cx('text-right', { 'text-nowrap': props.deviceFeature.last_value })}> | |||
There was a problem hiding this comment.
Can you do a stricter type check on this ? If last_value = 0, (ex: temperature = 0°C) then it'll be "false" here, but we want true.
check only if null
| @@ -51,7 +52,7 @@ const SensorDeviceType = ({ children, ...props }) => ( | |||
| </td> | |||
| )} | |||
| {props.deviceFeature.category === DEVICE_FEATURE_CATEGORIES.MOTION_SENSOR && ( | |||
| <td class="text-right"> | |||
| <td class={cx('text-right', { 'text-nowrap': props.deviceFeature.last_value })}> | |||
There was a problem hiding this comment.
Here it should be last_value_changed not last_value.
|
Before:
After:
|
atrovato
force-pushed
the
atrovato/issue925
branch
from
15dd08a to
f21399c
Compare
|
Thanks for your changes! Good for me. |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
Fixes GladysAssistant#925 Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #925
Do not allow to display device value on multiple lines (except for "no value received").