Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding footer, version and links in front #44

Merged
merged 3 commits into from
Nov 29, 2015
Merged

Adding footer, version and links in front #44

merged 3 commits into from
Nov 29, 2015

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Nov 20, 2015

@Pierre-Gilles
Copy link
Contributor

Thanks for the PR, I just saw it ! I will give a look this week :)

@VonOx
Copy link
Contributor Author

VonOx commented Nov 23, 2015

Yeah no problem.

FYI , i have followed an issue from adminlte repo ( ColorlibHQ/AdminLTE#88 (comment) ) to implement the footer ( not supported in V1.X )

Pierre-Gilles added a commit that referenced this pull request Nov 29, 2015
Adding footer, version and links in front
@Pierre-Gilles Pierre-Gilles merged commit 0c1b049 into GladysAssistant:master Nov 29, 2015
@Pierre-Gilles
Copy link
Contributor

Very nice, looks great :)

@Pierre-Gilles
Copy link
Contributor

I'll just add "var" before defining a variable ( ex : var fs = require('fs'); ), it's cleaner.

bertrandda pushed a commit to bertrandda/Gladys that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants