Skip to content

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add missing icon.
I use "cpu" icon for the device temperature icon: https://feathericons.com/?query=cpu

image

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 96.81% // Head: 96.81% // No change to project coverage 👍

Coverage data is based on head (75d2766) compared to base (825c4e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         660      660           
  Lines        9628     9628           
=======================================
  Hits         9321     9321           
  Misses        307      307           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 4386321 into GladysAssistant:master Nov 1, 2022
@relativeci
Copy link

relativeci bot commented Nov 1, 2022

Job #667: Bundle Size — 7.05MiB (~+0.01%).

4386321(current) vs 825c4e2 master#654(baseline)

Metrics (2 changes)
                 Current
Job #667
     Baseline
Job #654
Initial JS 3.11MiB(~+0.01%) 3.11MiB
Initial CSS 294.87KiB 294.87KiB
Cache Invalidation 43.98% 43.97%
Chunks 52 52
Assets 148 148
Modules 1265 1265
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 124 124
Duplicate Packages 10 10
Total size by type (1 change)
                 Current
Job #667
     Baseline
Job #654
CSS 312.84KiB 312.84KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 5MiB (~+0.01%) 5MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #667 reportView master branch activity

@atrovato atrovato deleted the device-temp-icon branch March 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants