Skip to content

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Sep 24, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • ~~[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.~~
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix fallback text and frenglish in Broadlink integration.

Linked to https://community.gladysassistant.com/t/broadlink-service/7157/75?u=alextrovato

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 96.77% // Head: 96.70% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (a1ed67c) compared to base (505df71).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
- Coverage   96.77%   96.70%   -0.07%     
==========================================
  Files         654      647       -7     
  Lines        9662     9346     -316     
==========================================
- Hits         9350     9038     -312     
+ Misses        312      308       -4     
Impacted Files Coverage Δ
server/utils/device.js
server/utils/constants.js
server/utils/slugify.js
server/lib/device/index.js
server/lib/index.js
server/models/device.js
server/lib/http/index.js

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles
Copy link
Contributor

@atrovato Thanks for this PR! I'm not able to test it, have you tested it?

As it's just frontend, if you are confident it's working fine, I can merge it, code looks good for me.

@atrovato
Copy link
Contributor Author

Yes just a frontend fix, it works fine.
You can see the bug on demo, creating a new television remote, and the fix on this branch.

@Pierre-Gilles Pierre-Gilles merged commit a1e079e into GladysAssistant:master Oct 3, 2022
@relativeci
Copy link

relativeci bot commented Oct 3, 2022

Job #515: Bundle Size — 7.02MB (~+0.01%).

a1e079e vs 980d721

Changed metrics (2/10)
Metric Current Baseline
Initial JS 2.98MB(~+0.01%) 2.98MB
Cache Invalidation 66.17% 42.33%
Changed assets by type (1/7)
            Current     Baseline
JS 4.99MB (~+0.01%) 4.99MB

View Job #515 full report

euguuu pushed a commit to euguuu/Gladys that referenced this pull request Oct 4, 2022
@atrovato atrovato deleted the broadlink-labels branch March 18, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants