-
-
Notifications
You must be signed in to change notification settings - Fork 292
Shutter/curtain device #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutter/curtain device #1576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 630 630
Lines 9267 9269 +2
=======================================
+ Hits 8956 8958 +2
Misses 311 311
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it for cover devices (shutter and curtain), BUT we have same problème if we looking for "capteur", wich is a category word, not a feature. The problem is more on the select element and its filter feature. It filters only on selectable elements, no on matching parent group. |
9f33b87
to
8f81ccc
Compare
@atrovato Nice! Could you make the UX a bit better when the button are clicked? There are no feedbacks right now, and it's hard to know if it's working or if it's bugged! See video: volet-test.mov |
front/src/components/boxs/device-in-room/device-features/CoverDeviceFeature.jsx
Outdated
Show resolved
Hide resolved
8f81ccc
to
14c3b10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me with the feedback, thanks for this PR ! 🙏
Job #439: Bundle Size — 6.85MB (+0.16%).Changed metrics (5/10)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add curtain/shutter feature.
Not used by services for now.