Skip to content

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add curtain/shutter feature.
Not used by services for now.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #1576 (14c3b10) into master (ce21420) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1576   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         630      630           
  Lines        9267     9269    +2     
=======================================
+ Hits         8956     8958    +2     
  Misses        311      311           
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne trouve pas la feature dans l'intégration MQTT

Screenshot 2022-07-28 at 15 30 13

@atrovato
Copy link
Contributor Author

I fixed it for cover devices (shutter and curtain), BUT we have same problème if we looking for "capteur", wich is a category word, not a feature.

The problem is more on the select element and its filter feature. It filters only on selectable elements, no on matching parent group.

@atrovato atrovato force-pushed the roller-shutter branch 2 times, most recently from 9f33b87 to 8f81ccc Compare July 31, 2022 12:33
@atrovato atrovato requested a review from Pierre-Gilles August 3, 2022 19:33
@Pierre-Gilles
Copy link
Contributor

@atrovato Nice!

Could you make the UX a bit better when the button are clicked? There are no feedbacks right now, and it's hard to know if it's working or if it's bugged!

See video:

volet-test.mov

@atrovato
Copy link
Contributor Author

atrovato commented Aug 6, 2022

I add the 'active' class to keep last selected state (and last received state) as selected button.

@atrovato atrovato mentioned this pull request Aug 6, 2022
6 tasks
@atrovato atrovato requested a review from VonOx August 26, 2022 07:49
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me with the feedback, thanks for this PR ! 🙏

@Pierre-Gilles Pierre-Gilles merged commit 8edd86d into GladysAssistant:master Sep 8, 2022
@relativeci
Copy link

relativeci bot commented Sep 8, 2022

Job #439: Bundle Size — 6.85MB (+0.16%).

8edd86d vs d85ed67

Changed metrics (5/10)
Metric Current Baseline
Initial JS 2.88MB(+0.08%) 2.88MB
Cache Invalidation 62.54% 62.4%
Modules 1261(+0.16%) 1259
Duplicate Modules 21(+5%) 20
Duplicate Code 0.56%(+12%) 0.5%
Changed assets by type (1/7)
            Current     Baseline
JS 4.88MB (+0.23%) 4.87MB

View Job #439 report on app.relative-ci.com

@atrovato atrovato deleted the roller-shutter branch October 31, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants