Skip to content

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #1177 (7d610c6) into master (63de819) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
+ Coverage   96.30%   96.33%   +0.02%     
==========================================
  Files         640      640              
  Lines        8145     8155      +10     
==========================================
+ Hits         7844     7856      +12     
+ Misses        301      299       -2     
Impacted Files Coverage Δ
server/lib/device/camera/camera.command.js 94.11% <100.00%> (+19.11%) ⬆️
.../device/humidity-sensor/humidity-sensor.command.js 100.00% <100.00%> (ø)
server/lib/device/light/light.command.js 100.00% <100.00%> (ø)
...e/temperature-sensor/temperature-sensor.command.js 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63de819...7d610c6. Read the comment docs.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review May 3, 2021 07:37
@Pierre-Gilles Pierre-Gilles merged commit 2c0c3c5 into master May 3, 2021
@Pierre-Gilles Pierre-Gilles deleted the fix-chat-issues branch May 3, 2021 07:54
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
…ands (GladysAssistant#1177)

* Add brain E2E test to check if response of node-nlp change

* Fix get temperature in room chat command

* Fix get humidity in room in chat

* Fix get camera image command

* Fix light turn on/turn off command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant