-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows a scene to trigger another scene #1124
Conversation
8417200
to
593df1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 644 644
Lines 8200 8205 +5
=======================================
+ Hits 7909 7914 +5
Misses 291 291
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks fine.
2 things:
- we may want to add a message in the UI to tell the user that scenes won't loop
- execution conditions of the child scene are ignored (to execute it), maybe the user needs to know it too
what about a ℹ️ tooltip on scene selection box?
360b3ff
to
009b4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ff4a7c7
to
96c2796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me this time! Thanks for the PR, great work 🙏
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.Description of change
This change adds an action to scenes which triggers another scene.
A few assumptions have been made here which I'd be happy to revisit based on feedback:
If you're happy with the approach, I'll go ahead and update the docs.
Closes #797