Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token balance loading #4740

Closed
wants to merge 24 commits into from
Closed

Conversation

lovelgeorge99
Copy link
Collaborator

@lovelgeorge99 lovelgeorge99 commented Sep 16, 2024

added loading spinner when fetching the balance and a check to see if the user wallet is connected before calling the fetchTokenBalance function

2024-09-16.15-58-34.mp4

Summary by CodeRabbit

Release Notes

  • New Features

    • Added new labels for improved user guidance regarding network connection and eligibility for matching in multiple languages (Catalan, English, Spanish).
    • Introduced conditional rendering in donation components to enhance user experience based on donation type (QR donations).
  • Bug Fixes

    • Improved handling of loading states for token balances to provide better feedback during asynchronous operations.
  • Style

    • Enhanced layout responsiveness in the Project GIVback Toast component for better adaptability across different screen sizes.

Meriem-BM and others added 24 commits September 9, 2024 13:40
…ng-donation

hotifx: prevent projects with Endaoment label from showing recurring donation view
…efault

HOTFIX: Comment-out-recurring-donation-default
Hotifx: adding gnosis safe back to connectors
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:00pm

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several updates across multiple language localization files and components related to the donation process. New labels are added to enhance user guidance regarding network connectivity and Stellar's eligibility for matching donations. Additionally, several components are modified to improve the user interface and control flow based on the type of donation being processed, particularly for QR donations.

Changes

File Change Summary
lang/ca.json, lang/en.json, lang/es.json Added new labels for network checks and Stellar eligibility; modified existing labels for formatting and clarity.
src/components/views/donate/DonateIndex.tsx Introduced a boolean variable to determine if the donation is via QR, adjusting UI rendering based on this condition.
src/components/views/donate/DonationCard.tsx Added a boolean variable to check if the project is an 'endaoment' project, modifying logic for setting the active tab.
src/components/views/donate/OnTime/DonateQFEligibleNetworks.tsx Added a prop for navigation and adjusted rendering logic based on whether the donation is a QR donation.
src/components/views/donate/OnTime/SelectTokenModal/QRCodeDonation/QRDonationCard.tsx Introduced a new component for eligible networks and refined handling of donation states with a new state variable for QR donations.
src/components/views/donate/OnTime/SelectTokenModal/SelectTokenModal.tsx Added a loading state for fetching token balances, improving user feedback during asynchronous operations.
src/components/views/project/ProjectGIVbackToast.tsx Modified the width of a styled component for responsiveness and adjusted media query breakpoints for layout changes on larger screens.

Possibly related PRs

  • Main #4340: Modifies lang/en.json to include a label indicating Stellar is not eligible for matching, relating to user guidance on eligibility.
  • merge main into develop #4342: Updates lang/en.json with a message about Stellar's eligibility, reinforcing changes in the main PR.
  • added sorting to tokens #4416: Introduces sorting functionality for tokens, potentially improving the donation process experience.
  • Hotfix - fix stellar doante card UI #4734: Adds a label in lang/en.json stating that Stellar is not eligible for matching, aligning with the main PR's focus on user messaging.

🐇 In the meadow, changes bloom bright,
Labels added, guiding the light.
Donations flow, with clarity in sight,
QR paths clear, making it right.
With each click, a hop in delight! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants