Fix some UI stuff for stellar feature

[mohammadranjbarz]

related to #4697 #4698 #4696

Summary by CodeRabbit

• New Features

  • Introduced an inline toast notification prompting users to sign in for potential givebacks when eligible tokens are selected.
  • Added external links for wallet addresses and transaction details, enhancing navigation to relevant resources.

• Improvements

  • Refined layout and styling of donation details for better visual alignment and readability.
  • Replaced standard links with external links for clearer navigation indication.
  • Expanded localization support for transaction details in Catalan, English, and Spanish.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 9, 2024 11:31am

[coderabbitai]

Walkthrough

The changes in this pull request enhance the user experience on the donation interface by introducing conditional rendering for user notifications and improving the layout of donation details. A toast message prompts users to sign in for potential givebacks, and navigation links to external resources for wallet addresses have been added. Additionally, the styling of components has been refined for better visual consistency.

Changes

File	Change Summary
src/components/views/donate/OnTime/SelectTokenModal/QRCodeDonation/QRDonationCard.tsx	Added conditional rendering for a toast message for unsigned users eligible for givebacks; minor style adjustments made.
src/components/views/transaction/DonationStatusSection.tsx	Introduced navigation links for wallet addresses, refined layout and styles for donation details, and replaced Link components with ExternalLink components.
lang/ca.json	Added localization entry for transaction detail in Catalan.
lang/en.json	Added localization entry for transaction detail in English.
lang/es.json	Added localization entry for transaction detail in Spanish.

Possibly related issues

• Stellar | changes on Donation page  #4422: The changes in this PR address the need for a toast message for users with Stellar addresses, as outlined in the issue.

Possibly related PRs

• Add givback toast to recrring donations #4207: This PR adds a "givback toast" feature, which is related to the user feedback mechanism introduced in the main PR for displaying a toast message when users are not signed in.
• Show qf related component on recurring donation #4285: This PR implements changes to display a QF-related component on recurring donation pages, which may relate to the user experience improvements in the main PR.
• Show selected token #4383: This PR focuses on showing the selected token, which is relevant to the user interaction enhancements made in the main PR.
• fix: update donation success QF Toast #4442: This PR updates the donation success QF Toast, which is directly related to the user feedback mechanisms discussed in the main PR.
• fix: 4453 update QF eligibility state when an error occurs #4459: This PR addresses the update of QF eligibility state when an error occurs, which can be linked to the user experience improvements in the main PR.

Suggested labels

Code Review

Poem

🐇 In the meadow where donations flow,
A toast for users, come see the glow!
With links to wallets, oh what a treat,
A journey of giving, so simple and sweet.
Sign in for givebacks, don't miss your chance,
Together we flourish, in this joyful dance! 🌼

Tip

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7938cec and 519b32c.

Files selected for processing (4)

• lang/ca.json (1 hunks)
• lang/en.json (1 hunks)
• lang/es.json (1 hunks)
• src/components/views/transaction/DonationStatusSection.tsx (11 hunks)

Files skipped from review due to trivial changes (3)

• lang/ca.json
• lang/en.json
• lang/es.json

Additional comments not posted (5)

src/components/views/transaction/DonationStatusSection.tsx (5)

30-30: New import added for navigation utility.

The import of slugToProjectView from @/lib/routeCreators is added to facilitate navigation to project views. This is a good addition as it enhances the navigation capabilities within the application.

---

186-187: Addition of constants for external links.

The constants STELLAR_TRANSACTION_LINK and STELLAR_ADDRESS_LINK have been added to construct URLs for Stellar wallet addresses and transaction details. This is a positive change as it centralizes the URLs and makes the code more maintainable.

---

274-280: Improved project title linking.

The use of slugToProjectView to generate URLs for project titles is a good practice. It ensures that the links are dynamically generated based on the project slug, enhancing the flexibility and maintainability of the code.

---

244-250: Enhanced display of token and wallet information.

The use of TokenIcon to display the token symbol and the use of ExternalLink for wallet addresses are good practices. These changes improve the user interface by making it more informative and user-friendly.

However, ensure that the TokenIcon component is tested thoroughly to handle different tokens correctly.

Also applies to: 262-266, 290-294

---

319-326: External link for transaction details.

The implementation of an external link to view transaction details on the Stellar explorer is well done. It enhances the user experience by providing direct access to transaction information.

Ensure that the IconExternalLink is visually aligned with the link text for better UI consistency.

Verification successful

---

IconExternalLink is visually aligned with the link text.

The IconExternalLink is used within a Flex component with $alignItems='center', ensuring it is visually aligned with the link text. The gap='8px' provides appropriate spacing between the elements, maintaining UI consistency. No further action is needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the visual alignment of IconExternalLink with the link text.

# Test: Search for the IconExternalLink usage. Expect: Proper alignment with the link text.
rg --type typescript -A 5 $'IconExternalLink'

Length of output: 79

---

Script:

#!/bin/bash
# Description: Verify the visual alignment of IconExternalLink with the link text.

# Test: Search for the IconExternalLink usage in TypeScript files.
rg --type ts -A 5 'IconExternalLink'

Length of output: 35038

---

Script:

#!/bin/bash
# Description: Search for the specific section in DonationStatusSection.tsx where IconExternalLink is used.

# Test: Search for IconExternalLink usage in DonationStatusSection.tsx to verify alignment with link text.
rg --type ts -A 10 'IconExternalLink' src/components/views/transaction/DonationStatusSection.tsx

Length of output: 846

---

Script:

#!/bin/bash
# Description: Gather more context around IconExternalLink usage in DonationStatusSection.tsx.

# Test: Search for more lines around IconExternalLink usage to verify alignment with link text.
rg --type ts -A 20 -B 10 'IconExternalLink' src/components/views/transaction/DonationStatusSection.tsx

Length of output: 2066

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Meriem-BM]

Thanks @mohammadranjbarz, will just add some modifications and merge it

[mohammadranjbarz]

Thanks @mohammadranjbarz, will just add some modifications and merge it

@Meriem-BM Thank you