Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove qf-eligibility & passport page + tempo change for QA test #4460

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

Meriem-BM
Copy link
Collaborator

@Meriem-BM Meriem-BM commented Jul 22, 2024

Related to #4453 (comment) & #4247 (comment)

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced responsive design for the Passport Modal, improving user experience across different screen sizes.
    • Introduced a new styled component for improved layout in the user profile section.
  • Performance Improvements

    • Updated data fetching policy for passport scores to utilize cached data while fetching updates, enhancing overall performance and user experience.
  • Bug Fixes

    • Removed redirect behavior from the /passport route, improving navigation control.
  • Chores

    • Removed obsolete route from the routing configuration, reflecting a streamlined application flow.
    • Removed localization labels related to identity verification and passport scoring to simplify user interface.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:19am

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Walkthrough

The recent updates enhance the user experience by improving the responsiveness of the PassportModal component and optimizing the fetchPassportScore function to use caching. Changes in routing, the introduction of a new styled component, and the removal of outdated labels streamline navigation and simplify the interface, indicating a shift in focus for the application.

Changes

Files Change Summary
src/components/modals/PassportModal.tsx Added media query for responsive design, setting StyledWrapper width to 600px for tablets.
src/services/passport.ts Updated fetchPassportScore to use 'cache-and-network' fetch policy for improved performance.
next.config.js Removed redirect rule from /passport to /qf-eligibility, altering user navigation.
src/components/views/userProfile/QFDonorEligibilityCard.tsx Introduced a new styled component QFEligibilityStateSection for better encapsulation and layout.
src/lib/constants/Routes.ts Removed route QFElegibility with path '/qf-eligibility', indicating a shift in routing configuration.
lang/*.json (ca.json, en.json, es.json, t_ca.json, t_es.json) Removed several labels related to donation amplification and identity verification, simplifying user experience.

Poem

🐇 In a modal bright and spry,
With queries fine, it catches the eye.
Fetching scores from the cache with glee,
Performance blooms, as fresh as can be!
Hopping through screens, both wide and small,
A responsive tale, together we’ll enthrall! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3b4fc54 and be87617.

Files selected for processing (1)
  • src/services/passport.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/services/passport.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Meriem-BM Meriem-BM requested a review from kkatusic July 22, 2024 15:11
@Meriem-BM Meriem-BM changed the title tempo change so QA can test refreshPassport score when it's failing Fix: remove qf-eligibility & passport page + tempo change for QA test Jul 23, 2024
@Meriem-BM Meriem-BM requested a review from RamRamez July 23, 2024 07:57
Copy link
Collaborator

@kkatusic kkatusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;) , thx @Meriem-BM

@Meriem-BM Meriem-BM merged commit f62777f into develop Jul 23, 2024
3 checks passed
@Meriem-BM Meriem-BM deleted the fix/MBD_errors branch July 23, 2024 12:22
@coderabbitai coderabbitai bot mentioned this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants