Fix verify button & tag #4372

kkatusic · 2024-07-03T14:49:54Z

Fully Verified New Projects when viewed still shows the "Verify Tag" #4365

@LatifatAbdullahi fixed project action dropdown menu when verify will show to user. Also added i18 label to verify project on single project page.

One combination was missing, when project verification form has been verified, but not verified project.

Summary by CodeRabbit

New Features
- The ProjectGIVbackToast component now supports dynamic labeling for the verification button, enhancing internationalization and localization based on user language preferences.
Bug Fixes
- Addressed issues related to project verification status checks in the ProjectActions component, ensuring more accurate handling of verification forms.

one combination was missing, when project verification form has been verified, but not verified project

vercel · 2024-07-03T14:49:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2024 11:23am

coderabbitai · 2024-07-03T14:50:00Z

Walkthrough

The recent updates focus on enhancing the internationalization and verification logic of the project-related components within the application. The ProjectGIVbackToast component now features a dynamically generated button label for better localization support. Additionally, the ProjectActions component's verification logic has been refined to handle project verification status and form presence conditions more effectively.

Changes

File Path	Summary
`.../project/ProjectGIVbackToast.tsx`	Updated button label to dynamically fetch text using `formatMessage`, enhancing localization.
`.../projectsTab/ProjectActions.tsx`	Modified condition logic for project verification status and form presence.

Sequence Diagram(s)

No sequence diagrams are necessary for these changes as they involve minor updates to the verification logic and label rendering without altering the main control flow.

Poem

In the code where projects toast,
A verification we now boast,
Dynamic labels here to show,
Languages of users flow.
Actions check, conditions set,
Verification's better yet.
🎉👨‍💻📈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

LatifatAbdullahi · 2024-07-03T15:22:59Z

Noted

RamRamez

@kkatusic I believe we should only rely on project.verified to check for verification status. Also in backend we only check that field.

I removed the fields causing this error in AdminJS. I think the FE logic is ok.

kkatusic · 2024-07-11T15:26:14Z

@kkatusic I believe we should only rely on project.verified to check for verification status. Also in backend we only check that field.

I removed the fields causing this error in AdminJS. I think the FE logic is ok.

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

RamRamez · 2024-07-16T11:45:57Z

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

kkatusic · 2024-07-16T11:50:36Z

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

Thx @RamRamez , but like I said before, we need this condition:

(!project.verified && project.projectVerificationForm === null)

from last commit

RamRamez · 2024-07-16T11:53:26Z

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

Thx @RamRamez , but like I said before, we need this condition:

(!project.verified && project.projectVerificationForm === null)

from last commit

@kkatusic Yes, I know. You can keep that one and just revert below commit.
003742e

This reverts commit 003742e.

kkatusic · 2024-07-16T12:02:19Z

Thx @RamRamez , reverted ;)

RamRamez

Thanks @kkatusic

MohammadPCh

Thanks @kkatusic

MohammadPCh · 2024-07-23T09:17:26Z

@kkatusic could you please resolve the conflict? then we can merge it.

kkatusic added 3 commits July 3, 2024 15:24

fixed project action menu on project list

1dae5a9

added i18 label for button verify

772de21

added missing flag for verification status

003742e

one combination was missing, when project verification form has been verified, but not verified project

kkatusic requested a review from MohammadPCh July 3, 2024 14:49

vercel bot deployed to Preview July 3, 2024 14:53 View deployment

kkatusic requested a review from RamRamez July 11, 2024 08:28

RamRamez requested changes Jul 11, 2024

View reviewed changes

Revert "added missing flag for verification status"

9c969df

This reverts commit 003742e.

vercel bot deployed to Preview July 16, 2024 12:05 View deployment

RamRamez approved these changes Jul 16, 2024

View reviewed changes

MohammadPCh approved these changes Jul 23, 2024

View reviewed changes

Merge branch 'develop' into fix_verify_tag

c726ceb

vercel bot deployed to Preview July 23, 2024 11:23 View deployment

kkatusic merged commit 1dd6f1e into develop Jul 23, 2024
3 checks passed

kkatusic deleted the fix_verify_tag branch July 23, 2024 11:32

coderabbitai bot mentioned this pull request Sep 9, 2024

Fixing boost button width #4706

Closed

coderabbitai bot mentioned this pull request Sep 24, 2024

Fix/givbacks verification form #4769

Merged

coderabbitai bot mentioned this pull request Oct 2, 2024

Fix/email project verification on mobile and tablet devices #4809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix verify button & tag #4372

Fix verify button & tag #4372

kkatusic commented Jul 3, 2024 •

edited

Loading

vercel bot commented Jul 3, 2024 •

edited

Loading

coderabbitai bot commented Jul 3, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

LatifatAbdullahi commented Jul 3, 2024

RamRamez left a comment

kkatusic commented Jul 11, 2024

RamRamez commented Jul 16, 2024

kkatusic commented Jul 16, 2024

RamRamez commented Jul 16, 2024

kkatusic commented Jul 16, 2024

RamRamez left a comment

MohammadPCh left a comment

MohammadPCh commented Jul 23, 2024

Fix verify button & tag #4372

Fix verify button & tag #4372

Conversation

kkatusic commented Jul 3, 2024 • edited Loading

Summary by CodeRabbit

vercel bot commented Jul 3, 2024 • edited Loading

coderabbitai bot commented Jul 3, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

LatifatAbdullahi commented Jul 3, 2024

RamRamez left a comment

Choose a reason for hiding this comment

kkatusic commented Jul 11, 2024

RamRamez commented Jul 16, 2024

kkatusic commented Jul 16, 2024

RamRamez commented Jul 16, 2024

kkatusic commented Jul 16, 2024

RamRamez left a comment

Choose a reason for hiding this comment

MohammadPCh left a comment

Choose a reason for hiding this comment

MohammadPCh commented Jul 23, 2024

kkatusic commented Jul 3, 2024 •

edited

Loading

vercel bot commented Jul 3, 2024 •

edited

Loading

coderabbitai bot commented Jul 3, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)