First of all, thank you for making ndlib it is great.
Describe the bug
The infection rate depends on the number of infected neighbors (tp_rate) but while this is implemented in the modes SI, SIS and SEIR this is not implemented in SIR or SWIR. To that extent, tp_rate is even declared in the SIRmodel (
) but then never used. Oddly, the documentation doesn't mention
tp_rate, so the behaviour is inconsistent among otherwise similar models.
To Reproduce
Steps to reproduce the behavior:
- NDlib version: 5.1.1
- Operating System: Any
- Python version: Any
- Version(s) of NDlib required libraries: NA
Expected behavior
To use tp_rate throughout and allow the user to set it (if needed).
First of all, thank you for making
ndlibit is great.Describe the bug
The infection rate depends on the number of infected neighbors (
tp_rate) but while this is implemented in the modesSI,SISandSEIRthis is not implemented inSIRorSWIR. To that extent,tp_rateis even declared in theSIRmodel (ndlib/ndlib/models/epidemics/SIRModel.py
Line 31 in 5493bbb
tp_rate, so the behaviour is inconsistent among otherwise similar models.To Reproduce
Steps to reproduce the behavior:
Expected behavior
To use
tp_ratethroughout and allow the user to set it (if needed).