Add author info, and relicense MIT OR Apache-2.0 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See GitoxideLabs#1 for details. For both authors' permission to relicense, see: - GitoxideLabs#1 (comment) - GitoxideLabs#1 (comment) This states explicitly in the readme that the content authors are Sebastian Thiel and Sidney Douw. That avoids ambiguity or confusion that might arise from the commit history (the commits introducing the content all show Sebastian Thiel only, but they reflect the collaboration in the LRG videos), or from the repo being moved to the GitoxideLabs org (which might otherwise lead to the "about" text "Our sessions when learning Rust with gitoxide" being misinterpreted). The readme contained an incomplete list of video topics and commits that introduced material corresponding to those LRG videos. This retains that list, but notes that it is incomplete. This is for general clarity, but also more specifically to avoid giving the false impression that the newly added authorship information and license apply to only some of the topics' code.
Closed
Byron
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
This builds on #3, as discussed in #1. See the commit message for details (c181602), including references to where permission to relicense was given, a summary of how the readme was edited, and rationale for how the readme was edited.
I don't think I can merge this myself. I have write access to other repositories in the GitoxideLabs organization, but not to this one.
There are two possible changes that it occurs to me could be made in this PR, which I did not do, but which I mention in case they are wanted:
licenselines could be added to the crates'Cargo.tomlfiles. (Currently, this would belicense = "MIT OR Apache-2.0".) I would regard this to be optional since there is no plan to publish the crates to a registry such as crates.io.