rough FSCK for git-odb::Store #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they used many different ways of handling their parameters despite all boiling down to calling the same 'index::File::traverse()` method. This allows for more reuse of `Options` structs and generally makes clearer how these optinos are used.
That way, even empty slots can be identified as 'changed' compared to some older index even if they are empty. This makes it consistent, as indices refer to occupied slots only and protect themselves from changes using the generation flag, which usually comes first.
Re-use the index::integrity::Options for multi_index options as it's exactly the same. This opportunty was missed the previous we simplified these signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify integrity for the entire store, essentially calling all 'verify_integrity()' implementations of the underlying file types like indices and packs, allowing to deeply checking each and every object.
Note that this doesn't include connectivity checking until it's clear how that should best be implemented so that it can run fast on multi-core machines and to avoid recreating something like 'counting objects' which definitely isn't en-par even for a single core.
However, having a solid way to handle dependencies or to multi-thread it would certainly help with eventually implementing a conversion from SHA1 to SHA256.
Tasks
verify_integrity()for Storeverify_integrity()for loose ODBsfsckCLI command to one day also check connectivity and refs (aka reachability/dangling objects)