[config #185] add test for handling windows formatted files…

…which occour implicitly when checking out the repository fixtures on
windows, which are then windows formatted. From there the unholy
carriage return \r enters the compiled binary using include_bytes!
as a template, which then is used to initialize a repository.

In case of bare repositories, the implementation has to check if
it really is bare (i.e. bare = true) or just looks bare (because
there is no index, but that's the case in a new repository as well).

This check would use the config parser, which wouldn't consider carriage
returns and fail to parse the config file, making the opening of
repositories impossible on windows.

git-config/src/parser.rs

@@ -1367,7 +1367,7 @@ fn take_spaces(i: &[u8]) -> IResult<&[u8], &str> {
 
 fn take_newline(i: &[u8]) -> IResult<&[u8], (&str, usize)> {
     let mut counter = 0;
-    let (i, v) = take_while(|c| (c as char).is_ascii() && is_newline(c))(i)?;
+    let (i, v) = take_while(|c| (c as char).is_ascii() && (c == b'\r' || is_newline(c)))(i)?;
     counter += v.len();
     if v.is_empty() {
         Err(nom::Err::Error(NomError {

git-config/tests/fixtures/repo-config.crlf

@@ -0,0 +1,14 @@
+; hello
+# world
+
+[core]
+	repositoryformatversion = 0
+	bare = true
+[other]
+	repositoryformatversion = 0
+
+	bare = true
+
+# before section with newline
+[foo]
+	repositoryformatversion = 0

git-config/tests/integration_tests/file_integeration_test.rs

@@ -1,6 +1,14 @@
 use std::{borrow::Cow, convert::TryFrom};
 
 use git_config::{file::GitConfig, values::*};
+use std::path::Path;
+
+#[test]
+fn parse_config_with_windows_line_endings_successfully() {
+    GitConfig::open(Path::new("tests").join("fixtures").join("repo-config.crlf"))
+        .map_err(|err| err.to_string())
+        .unwrap();
+}
 
 /// Asserts we can cast into all variants of our type
 #[test]