Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the fixture lock timeout #1606

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Double the fixture lock timeout #1606

merged 1 commit into from
Sep 24, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented Sep 24, 2024 •
edited
Loading

Fixes #1605

As suggested in #1605 (comment), this increases the lock timeout gix-testtools uses when it runs fixture scripts.

If 6 minutes is too long, I can experiment with intermediate values.

Duration::from_mins is still marked experimental in the standard library, so I've continued to use Duration::from_secs with * 60 as before.

@EliahKagan
fix: Double the fixture lock timeout
39323c3 
This increases the lock timeout used in `gix-testtools` from 3 min
6 min. This seems to fix GitoxideLabs#1605.
@EliahKagan EliahKagan marked this pull request as ready for review September 24, 2024 10:02
@EliahKagan EliahKagan mentioned this pull request Sep 24, 2024
Closed
Byron
Byron approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I am glad this works.

And I am so looking forward to the day when there is a system that allows to keep issues, and reviews, and all metadata, directly in the repository and referenceable from commits.

@Byron Byron merged commit 8c9e827 into GitoxideLabs:main Sep 24, 2024
16 checks passed
@EliahKagan EliahKagan deleted the fixture-timeout branch September 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packed::iter::performance on riscv64 has PermanentlyLocked failure running fixture
2 participants
@EliahKagan @Byron