Wrong entry order in tree object #848
Assignees
Comments
|
Thanks for letting me know! There have been plenty of subtle bugs cropping up over time because of this. This should be the correct implementation. |
2 tasks
|
The fix was released with v0.29.2, and it should be pulled in automatically if the latest version of |
3 tasks
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this issue
Oct 14, 2024
This updates the "git_cmp_c" and "git_cmp_rs" links in the `gix_diff::tree::function::diff` documentation comment. - The significant change is to the "git_cmp_rs" link (the second link), which accounts for how files have renamed and how code has been moved, and also changed in GitoxideLabs#849 to fix issue GitoxideLabs#848. This hyperlink change completes the third task listed in GitoxideLabs#1627. - The other change is to update the "git_cmp_c" link at the same time. That code has not changed, and this is just referring to a later commit (the current tip of the master branch in git/git). The reason to also do this change is to make it easier to verify, both now and for anyone reading the documentation, that that link remains current.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Duplicates
Current behavior 😯
Current implementation sorts the tree entries alphabetically without looking at the entry type, but git (at least on Ubuntu) sorts it in a slightly different manner. Git virtually "adds" '/' to tree filenames.
git sorted list of entries:
and this implementation rakes into account only filenames.
Expected behavior 🤔
I'd expect this code of Ord trait implementation for Entry add '/' symbol to tree filenames for comparing/
Steps to reproduce 🕹
No response
The text was updated successfully, but these errors were encountered: