pixelmatch-py.git cannot be cloned with gix clone

[gl-yziquel]

Current behavior 😯

I tried to clone the pixelmatch-py.git repository on github. Here: https://github.com/whtsky/pixelmatch-py.git

It fails with Error: Process handshake with command "/bin/sh" "-c" "git-lfs filter-process" "--" failed

Expected behavior 🤔

Ideally, the git repository should get cloned, like all the other repositories that I've cloned with gix. (Thank you very much for that tool.)

Git behavior

The clone succeeds.

Steps to reproduce 🕹

Just clone. And see it fail.

[Byron]

Thanks a lot for letting me know! I could already reproduce a couple of issues related to git filter support, even though none of them is yours.

It fails with Error: Process handshake with command "/bin/sh" "-c" "git-lfs filter-process" "--" failed

Can it be that you are running this on windows? If so, the latest version from main should get you past this issue at least even though #1130 will probably be needed to make it all work.

It's strange that git lfs seems to work slightly differently and runs in to failures, even though I use it in gitoxide too, and there it works fine. I am looking forward to solve this issue :).

[gl-yziquel]

No. I'm on a linux box.

[Byron]

Oh, that's interesting!

Could you share the output of gix config filter?

Here is mine, and with it I am not running into the issue described here.

❯ gix config filter
# From '/Users/byron/.gitconfig' (User)
[filter "lfs"]
        required = true
        clean = git-lfs clean -- %f
        smudge = git-lfs smudge -- %f
        process = git-lfs filter-process

While at it, please also provide the version of git-lfs:

❯ git-lfs --version
git-lfs/3.4.0 (GitHub; darwin arm64; go 1.20.6)

Thanks again!

[gl-yziquel]

Here:

mini-me@virtucon ~> gix config filter
Error: Could not find a git repository in '.' or in any of its parents within device limits below '/home'

mini-me@virtucon ~> git-lfs --version
git-lfs/3.3.0 (GitHub; linux amd64; go 1.18.1; git e6f011be)

I built gix by running cargo build on revision d257099bb87428986d1630d29b6d47430454e275. I'm using the binary generated in target/debug.

[Byron]

Thanks! git-lfs seems new enough to assume that's not part of the problem.

Can you retry gix config filter from within a repository please? For now it can't work without a repo.

[gl-yziquel]

Here:

mini-me@virtucon ~/h/c/webob (main)> gix config filter
# From '/home/mini-me/.gitconfig' (GitInstallation)
[filter "lfs"]
        smudge = git-lfs smudge -- %f
        process = git-lfs filter-process
        required = true
        clean = git-lfs clean -- %f

[Byron]

It appears that the options are the same as mine.

Looking at the error definition itself I see that the error presented here is lacking a source, it was probably truncated when copying.

Would you post the whole error here as well?

[gl-yziquel]

Sorry. I only have this output:

mini-me@virtucon ~/mud> gix clone https://github.com/whtsky/pixelmatch-py.git
 19:20:19 indexing done 735.0 objects in 0.05s (15.1k objects/s)
 19:20:19 decompressing done 581.2KB in 0.05s (11.9MB/s)
 19:20:19     Resolving done 735.0 objects in 0.15s (4.9k objects/s)
 19:20:19      Decoding done 4.4MB in 0.15s (28.9MB/s)
 19:20:19 writing index file done 21.7KB in 0.00s (90.9MB/s)
 19:20:19  create index file done 735.0 objects in 0.20s (3.7k objects/s)
 19:20:19          read pack done 321.5KB in 0.23s (1.4MB/s)
Error: Process handshake with command "/bin/sh" "-c" "git-lfs filter-process" "--" failed

Caused by:
    0: Failed to read or write to the process
    1: Failed to decode the first four hex bytes indicating the line length: Invalid character
yziquel@hilbert ~/mud [1]> 

[Byron]

Thanks! Very helpful, even though it doesn't show much more.

What happens if you execute/run git-lfs just like that? Does it work? My guess would be that it fails to launch the command. If so, does git lfs work?

If it runs fine, are you aware of any configuration that might affect git-lfs?

From what I see, it manages to launch the program, but it doesn't respond according to protocol, which would be unusual to say the least.

[Byron]

Oh, and as a follow-up test, can you disable the process = git-lfs filter-process line? What happens then?