Add support for sub sections (anchor links) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soreine
suggested changes
Jan 19, 2017
| @@ -53,7 +53,7 @@ <h3 class="panel-title">{{ "FAQ_RELATED_ARTICLES"|t }}</h3> | |||
| {% for related in page.related %} | |||
| {% set relatedArticle = getArticleByPath(related) %} | |||
| {% if relatedArticle %} | |||
| <a href="{{ relatedArticle.path|resolveFile }}" class="list-group-item">{{ relatedArticle.title }}</a> | |||
| <a href="{{ relatedArticle.path|resolveFile }}{{ relatedArticle.anchor }}" class="list-group-item">{{ relatedArticle.title }}</a> | |||
There was a problem hiding this comment.
This will find the first article with matching path, and use this article's anchor. But that's not really what we would like here. If we have several articles pointing to the same file, we should expect the related property to have the anchor included, so that related refer without ambiguity to a particular article.
So we should do something like getArticleByPathWithAnchor(related)... but this is not in the API. So I would not implement it until GitBook v4 is finished.
Do you have a use-case for this?
| @@ -22,7 +22,7 @@ <h3 class="panel-title"> | |||
| <div class="list-group"> | |||
| {% for article in part.articles %} | |||
| {% if article.path != readme.file.path %} | |||
| <a href="{{ article.path|resolveFile }}" class="list-group-item"> | |||
| <a href="{{ article.path|resolveFile }}{{ article.anchor }}" class="list-group-item"> | |||
There was a problem hiding this comment.
Great. I'll happily merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.