Skip to content

RND-8495: page group emoji and icon resolution #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

RND-8495: page group emoji and icon resolution #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fdad26
resolve icon for page group
BrettJephson Oct 27, 2025
419e457
chore: changeset
BrettJephson Oct 27, 2025
dc4af74
Merge branch 'main' into brett/RND-8495-page-group-emoji
BrettJephson Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ready-parrots-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"gitbook": patch
---

Fix icon resolution for page group
13 changes: 7 additions & 6 deletions packages/gitbook/src/lib/references.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,15 @@ export async function resolveContentRef(
}
} else {
const parentPage = (resolvePageResult?.ancestors || []).slice(-1).pop();
// When the looked up ref was a page group we use the page group title as resolved ref text.
// Otherwise use the resolved page title.
text =
// When the looked up ref was a page group we use the page group to resolve title and icon.
// Otherwise use the resolved page title and icon.
const pageOrGroup =
parentPage && contentRef.page === parentPage.id && parentPage.type === 'group'
? parentPage.title
: page.title;
? parentPage
: page;
text = pageOrGroup.title;
emoji = isCurrentPage ? undefined : page.emoji;
icon = <PageIcon page={page} style={iconStyle} />;
icon = <PageIcon page={pageOrGroup} style={iconStyle} />;
}

return {
Expand Down