Add isRoot prop to PagesList for root header offset #3759
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional isRoot prop to PagesList and apply 'group/root-page-list' when true. - Pass isRoot from TableOfContents for the top-level pages list. - Tighten PageGroupItem selector so the top negative margin (-mt-6) only applies in the root-page-list context, avoiding incorrect offset for nested groups.
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page group inside of another page group were masking other elements, this fix it.
Introduce an optional
isRootprop to thePagesListcomponent to apply specific styling for top-level pages. Adjust thePageGroupItemselector to ensure correct offset behavior in root context.