Skip to content

Implement a StylesProvider #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Implement a StylesProvider #3352

merged 3 commits into from
Jun 18, 2025

Conversation

conico974
Copy link
Contributor

This PR introduce a StylesProvider that we can use to pass tailwind css classes to client component.
It reduces the size of the RSC.
With this PR and #3339 , we can in some worst case scenario go from 41.8Mb to 14.3.
And we can iterate on this PR to improve this even further

Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: a6ef878

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 18, 2025, 3:37 PM
customers-v2 (Inspect) 👍 Changes approved 77 changed Jun 18, 2025, 3:38 PM
default (Inspect) ✅ No changes detected - Jun 18, 2025, 3:41 PM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 18, 2025, 3:43 PM
v2-vercel (Inspect) 👍 Changes approved 1 changed Jun 18, 2025, 3:45 PM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a solution for that: CSS or Tailwind utilities. Introducing another thing like that is not the way to go.

@gregberge gregberge dismissed their stale review June 18, 2025 13:28

Unblocking

@conico974 conico974 merged commit 8d3c656 into main Jun 18, 2025
21 checks passed
@conico974 conico974 deleted the gbo/reduce-class branch June 18, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants