Skip to content

revert to use withoutConcurrentExecution #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025
Merged

revert to use withoutConcurrentExecution #3292

merged 5 commits into from
Jun 10, 2025

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Jun 9, 2025

This PR reintroduce withoutConcurrentExecution, because on some big page like the MariaDB one, it will just crash. In order to avoid the previous issue on vercel, we use React.cache({})` as our global request context so that it doesn't leak to other request with fluid compute.

It also disable resolvingAnchorText on InlineLink because with it, the request will just timeout if there is too many of them in a single page

Copy link

linear bot commented Jun 9, 2025

Copy link

argos-ci bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 22 changed, 4 removed Jun 10, 2025, 4:37 PM
customers-v2 (Inspect) 👍 Changes approved 22 changed, 4 removed Jun 10, 2025, 4:53 PM
default (Inspect) 👍 Changes approved 14 changed Jun 10, 2025, 4:41 PM
v2-cloudflare (Inspect) 👍 Changes approved 14 changed Jun 10, 2025, 4:56 PM
v2-vercel (Inspect) 👍 Changes approved 14 changed Jun 10, 2025, 4:55 PM

Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: 0096568

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but when I think about it, we might still need to manage concurrency inside the use cache: imagine that the Node.js process receive 10 requests to generate pages in the same space, right now it'll result in 10 API requests to the same space for each of the top level requests.
I think we should manage concurrency at 2 levels:

  • Wrapping in the use cache: per-request using cache(() => {})
  • Wrapping the API call in the use cache: global in the process

@conico974 conico974 deleted the conico/rnd-7263 branch June 10, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants