Skip to content

Pass spec validation errors through OpenAPIParseError #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025

Conversation

nolannbiron
Copy link
Member

No description provided.

@nolannbiron nolannbiron self-assigned this May 17, 2025
Copy link

changeset-bot bot commented May 17, 2025

🦋 Changeset detected

Latest commit: d55bf70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@gitbook/openapi-parser Patch
gitbook Patch
@gitbook/react-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nolannbiron nolannbiron requested a review from gregberge May 17, 2025 14:26
@nolannbiron nolannbiron changed the title Pass scalar's errors through OpenAPIParseError Pass scalar's validation errors through OpenAPIParseError May 17, 2025
@nolannbiron nolannbiron changed the title Pass scalar's validation errors through OpenAPIParseError Pass spec validation errors through OpenAPIParseError May 17, 2025
Copy link

argos-ci bot commented May 17, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 4 changed May 17, 2025, 2:33 PM
customers-v2 (Inspect) 👍 Changes approved 80 changed May 17, 2025, 2:36 PM
default (Inspect) ✅ No changes detected - May 17, 2025, 2:36 PM
v2-cloudflare (Inspect) ✅ No changes detected - May 17, 2025, 2:38 PM
v2-vercel (Inspect) ✅ No changes detected - May 17, 2025, 2:37 PM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give more context about it? What do we want to do here?

Copy link
Member Author

@gregberge yes, I want to get scalar validation errors to display them in GBX. If a spec is invalid, we should tell the user what's invalid (feedback from Bird) so they don't have to find where the problem is in their spec. Currently in GBX we just say "Your spec is invalid" and that's it

@nolannbiron nolannbiron merged commit d00dc8c into main May 18, 2025
21 checks passed
@nolannbiron nolannbiron deleted the nolann/openapi-validation-error branch May 18, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants