Skip to content

Conversation

@nolannbiron
Copy link
Member

No description provided.

@nolannbiron nolannbiron requested a review from gregberge May 2, 2025 07:40
@linear
Copy link

linear bot commented May 2, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 82bef3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/react-openapi Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci
Copy link

argos-ci bot commented May 2, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 2 changed May 2, 2025, 9:42 AM
customers-v2 (Inspect) 👍 Changes approved 79 changed May 2, 2025, 9:44 AM
default (Inspect) 👍 Changes approved 10 changed May 2, 2025, 9:46 AM
v2-vercel (Inspect) 👍 Changes approved 6 changed May 2, 2025, 9:45 AM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's good. A required parent does not mean children are required. Also we have ancestors to know that.

@nolannbiron
Copy link
Member Author

@gregberge You can require children in parent like this :

xxSchema:
      required:
        - name
        - type
      allOf:
        - $ref: '#/components/schemas/...'
        - ...

I'll try to get this from ancestors 👍🏻

@gregberge
Copy link
Contributor

Hmm ok so it's valid. Yeah let's use the latest ancestor and we are good to go.

@nolannbiron nolannbiron force-pushed the nolann/rnd-6827-using-allof-merge-schema-doesnt-reflect-required-properties branch from 00a9df4 to 82bef3e Compare May 2, 2025 09:36
@nolannbiron nolannbiron merged commit 20ebecb into main May 2, 2025
20 checks passed
@nolannbiron nolannbiron deleted the nolann/rnd-6827-using-allof-merge-schema-doesnt-reflect-required-properties branch May 2, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants