Skip to content

Fix openapi CR preview #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nolannbiron
Copy link
Member

The DisclosureGroup was implemented as a <button>, but when we had an openapi-select inside it, this caused an error because a <button> cannot be nested inside another <button>. This PR changes the DisclosureGroup trigger to a <div> that behaves like a button.

@nolannbiron nolannbiron requested a review from gregberge April 30, 2025 09:33
Copy link

linear bot commented Apr 30, 2025

Copy link

changeset-bot bot commented Apr 30, 2025

🦋 Changeset detected

Latest commit: e45893c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/react-openapi Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Apr 30, 2025, 9:39 AM
customers-v2 (Inspect) ✅ No changes detected - Apr 30, 2025, 9:41 AM
default (Inspect) 👍 Changes approved 6 changed Apr 30, 2025, 9:42 AM
v2-vercel (Inspect) ✅ No changes detected - Apr 30, 2025, 9:44 AM

@nolannbiron nolannbiron merged commit 42ca7e1 into main Apr 30, 2025
20 checks passed
@nolannbiron nolannbiron deleted the nolann/rnd-7016-preview-crashes-on-pages-with-inserted-openapi-block branch April 30, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants