Refactor Table to use flex layouts #2622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
viktorrenkema
commented
Dec 11, 2024
viktorrenkema
commented
Dec 11, 2024
packages/gitbook/src/components/DocumentView/Table/table.module.css
Outdated
Show resolved
Hide resolved
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
viktorrenkema
commented
Dec 11, 2024
packages/gitbook/src/components/DocumentView/Table/RecordColumnValue.tsx
Show resolved
Hide resolved
SamyPesse
approved these changes
Dec 11, 2024
packages/gitbook/src/components/DocumentView/Table/RecordRow.tsx
Outdated
Show resolved
Hide resolved
viktorrenkema
force-pushed
the
viktor/rnd-3264/table-widths-to-flex
branch
from
b8fa4d4 to
2ff1075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we render Tables. It now implements a strategy closer to the GitBook in-app editor, where we use flexbox for layout instead of semantic
<table><tr>etc, and useroleon divs for these instead.The change was motivated by limitations of layout with html table elements. Our columns can be sized in 3 different ways:
1. Set to auto-size by default, these columns share the available width
2. Explicitly set by the user by dragging column separator (we then turn off auto-size)
3. Auto-size is turned off without setting a width, we then default to a fixed width of 100px
This lead to a bunch of layout headaches, like:
<table>take upwidth: 100%of the available space, columns would always increase in size when possible, even though if we/users explicitly set a customwidthon a column through dragging the column separatorwidth: fit-content, which also allows for tables in smaller width than the page (altho this is currently broken, but then any columns with no set width should enforce auto-sizing. but this is not possible without measuring the DOM (inefficient), as the parent is set to fit-content, not 100%Ultimately using flexbox gives us a lot more flexibility and potential for adding more features, and we're closer to the editor.
This PR also fixes a number of bugs: