Fix sublinks display on mobile #2620
Conversation
|
|
GitBook Preview |
gregberge
force-pushed
the
greg/rnd-5468-the-sublink-of-header-will-disappear-when-the-width-of-the
branch
from
ebd6bad to
d9383ac
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…appear-when-the-width-of-the
| active?: boolean; | ||
| className?: ClassValue; |
There was a problem hiding this comment.
I'm not familiar with the GBO dev env yet : why isn't that a string?
There was a problem hiding this comment.
We manipulate clsx values, but IMO we should not. All components should only accept a className?: string and if you need to merge thing you can do it when you pass the prop: <Any className={clsx(...)} /> like we do in the app.
| <Link | ||
| href={href} | ||
| prefetch={false} | ||
| className={tcls( |
There was a problem hiding this comment.
Curious to know why we went for tcls instead of clsx on GBO?
There was a problem hiding this comment.
It's a mistake, but it's like that from the beginning. At some point we should change it to improve perfs.
gregberge
deleted the
greg/rnd-5468-the-sublink-of-header-will-disappear-when-the-width-of-the
branch
Uh oh!
There was an error while loading. Please reload this page.