RND-3113: expand when expandable anchor #2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he expandable block.
🦋 Changeset detectedLatest commit: b06a6ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
SamyPesse
reviewed
Aug 19, 2024
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/DocumentView/Expandable/Expandable.tsx
Outdated
Show resolved
Hide resolved
BrettJephson
force-pushed
the
brett/RND-3113-expandable-anchor
branch
from
6c37b49 to
54870cb
Compare
SamyPesse
reviewed
Aug 20, 2024
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
SamyPesse
approved these changes
Aug 20, 2024
packages/gitbook/src/components/DocumentView/Expandable/Details.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, anchor ids for expandable sections and also the content within expandable sections are now matched to the url hash.
If there's a match, expand the expandable and scroll into view.