Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1183 - updated examples to use the correct GRM arguments #1186

Merged
merged 1 commit into from
Jul 22, 2024
Merged

#1183 - updated examples to use the correct GRM arguments #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dist/azure/gitreleasemanager/addasset/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@
"helpMarkDown": "The access token to access GitHub with"
},
{
"name": "tagName",
"name": "milestone",
"type": "string",
"label": "The name of the release",
"label": "The milestone to use",
"defaultValue": "",
"required": true,
"helpMarkDown": "The name of the release"
"helpMarkDown": "The milestone to use"
},
{
"name": "assets",
Expand All @@ -71,4 +71,4 @@
"helpMarkDown": "The directory on which GitReleaseManager should be executed. Defaults to current directory"
}
]
}
}
8 changes: 4 additions & 4 deletions dist/azure/gitreleasemanager/publish/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@
"helpMarkDown": "The access token to access GitHub with"
},
{
"name": "tagName",
"name": "milestone",
"type": "string",
"label": "The name of the release",
"label": "The milestone to use",
"defaultValue": "",
"required": true,
"helpMarkDown": "The name of the release"
"helpMarkDown": "The milestone to use"
},
{
"name": "targetDirectory",
Expand All @@ -63,4 +63,4 @@
"helpMarkDown": "The directory on which GitReleaseManager should be executed. Defaults to current directory"
}
]
}
}
2 changes: 1 addition & 1 deletion docs/examples/azure/gitreleasemanager/addasset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
token: '$(GITHUB_TOKEN)'
owner: 'someOwner'
repository: 'someRepo'
tagName: '0.1.0'
milestone: '0.1.0'
assets: |
src/test.txt
src/test1.txt
Expand Down
2 changes: 1 addition & 1 deletion docs/examples/azure/gitreleasemanager/publish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
token: '$(GITHUB_TOKEN)'
owner: 'someOwner'
repository: 'someRepo'
tagName: '0.1.0'
milestone: '0.1.0'
```
2 changes: 1 addition & 1 deletion docs/examples/github/gitreleasemanager/addasset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
token: ${{ secrets.GITHUB_TOKEN }}
owner: 'someOwner'
repository: 'someRepository'
tagName: '0.1.0'
milestone: '0.1.0'
assets: |
src/test.txt
src/test1.txt
Expand Down
2 changes: 1 addition & 1 deletion docs/examples/github/gitreleasemanager/publish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
token: ${{ secrets.GITHUB_TOKEN }}
owner: 'someOwner'
repository: 'someRepository'
tagName: '0.1.0'
milestone: '0.1.0'
```
8 changes: 4 additions & 4 deletions src/__tests__/tools/gitreleasemanager/tool.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ describe('GitReleaseManagerTool', () => {
it('should return correct publish arguments', async () => {
const args = await tool.getPublishArguments({
...commonSettings,
milestone: 'tagName'
milestone: 'milestone'
} as GitReleaseManagerPublishSettings)

expect(args).toEqual([
Expand All @@ -307,7 +307,7 @@ describe('GitReleaseManagerTool', () => {
'--targetDirectory',
'targetDirectory',
'--tagName',
'tagName'
'milestone'
])
})
})
Expand All @@ -316,7 +316,7 @@ describe('GitReleaseManagerTool', () => {
it('should return correct add asset arguments', async () => {
const args = await tool.getAddAssetArguments({
...commonSettings,
milestone: 'tagName',
milestone: 'milestone',
assets: ['asset1', 'asset2']
} as GitReleaseManagerAddAssetSettings)

Expand All @@ -331,7 +331,7 @@ describe('GitReleaseManagerTool', () => {
'--targetDirectory',
'targetDirectory',
'--tagName',
'tagName',
'milestone',
'--assets',
`${path.join('targetDirectory', 'asset1')},${path.join('targetDirectory', 'asset2')}`
])
Expand Down