Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified in the reviewed change. Pre-merge checks |
|
|
Added in e6111ee9f: executable worked examples on the version-calculation page. Ten new test cases generate nine Mermaid histories covering competing configured/tag candidates, inherited Patch/Minor increments, equal-version ties, separate semantic and counting sources, and all three deployment modes. The examples assert full versions and source metadata. The tie case supplies controlled strategy candidates in both enumeration orders to isolate the timestamp selection rule; the other histories use normal strategy discovery. The generator now includes this sample family, and the maintenance guide and source-to-section map point to the new evidence. Validation:
These are representative checkpoints. The algorithm flowcharts remain manually authored and still require review when calculation rules change. CodeRabbit review was attempted but remains blocked by its organization-membership service error. |
|
@coderabbitai full review Please review the full current PR, including the documentation source-review guard and generated calculation examples. This draft is awaiting your review before it is marked ready. |
✅ Action performedFull review finished. |
|
Addressed the 18 Sonar annotations in All 13 checker tests pass, the existing source hashes still validate for all seven sections, and the diff check passes. The preceding running build is canceled before this push; CI and reviews will be checked again on the new head. |
There was a problem hiding this comment.
🔵 Needs a closer look
The extensive manually authored algorithm semantics require final domain-expert verification despite the strong automated safeguards.
0 open findings
What changed in this PR
Documents GitVersion’s version-calculation pipeline and adds safeguards that require algorithm documentation review when mapped implementation sources change.
Changes:
- Adds authored Mermaid flowcharts and test-generated examples.
- Adds source-to-section review manifests, validation, tests, and CI enforcement.
- Improves Mermaid validation, dark-theme rendering, navigation, and worktree detection.
| File | Description |
|---|---|
src/GitVersion.Core.Tests/IntegrationTests/DocumentationSamplesForVersionCalculation.cs |
Adds executable documentation scenarios. |
package.json |
Adds checker commands and JSDOM. |
package-lock.json |
Locks JSDOM dependencies. |
docs/version-calculation-map.json |
Maps documentation sections to sources. |
docs/scripts/validate-mermaid.mjs |
Initializes Mermaid with a DOM. |
docs/scripts/check-version-calculation.test.mjs |
Tests review enforcement. |
docs/scripts/check-version-calculation.mjs |
Implements source-review validation. |
docs/maintaining-version-calculation.md |
Documents the review workflow. |
docs/input/Shared/Sidebar/_ChildPages.cshtml |
Adds sidebar navigation. |
docs/input/docs/reference/version-sources.md |
Links the algorithm guide. |
docs/input/docs/learn/version-calculation.md |
Adds the algorithm documentation. |
docs/input/docs/learn/index.cshtml |
Adds the learning-page link. |
docs/input/docs/learn/how-it-works.md |
Links detailed calculation guidance. |
docs/input/assets/css/redesign.css |
Improves dark-theme Mermaid contrast. |
docs/diagrams/VersionCalculation_Strategies.mmd |
Diagrams strategy discovery. |
docs/diagrams/VersionCalculation_Selection.mmd |
Diagrams candidate selection. |
docs/diagrams/VersionCalculation_Overview.mmd |
Diagrams the overall pipeline. |
docs/diagrams/VersionCalculation_Mainline.mmd |
Diagrams Mainline traversal. |
docs/diagrams/VersionCalculation_Inheritance.mmd |
Diagrams branch inheritance. |
docs/diagrams/VersionCalculation_DeploymentModes.mmd |
Diagrams deployment modes. |
docs/diagrams/version-calculation.mmd |
Removes the legacy diagram. |
docs/diagrams/DocumentationSamplesForVersionCalculation_MergeMessageAndCountingSourceDiffer.mmd |
Adds merge-source example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_FeatureInheritsSourceIncrement_Patch.mmd |
Adds patch inheritance example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_FeatureInheritsSourceIncrement_Minor.mmd |
Adds minor inheritance example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_EqualCandidatesUseLatestSource.mmd |
Adds candidate tie example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_DeploymentModesProcessSameHistory_ManualDeployment.mmd |
Adds manual-mode example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_DeploymentModesProcessSameHistory_ContinuousDeployment.mmd |
Adds continuous-deployment example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_DeploymentModesProcessSameHistory_ContinuousDelivery.mmd |
Adds continuous-delivery example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_CompetingConfiguredAndTaggedVersions_TagWins.mmd |
Adds tag-winner example. |
docs/diagrams/DocumentationSamplesForVersionCalculation_CompetingConfiguredAndTaggedVersions_ConfigurationWins.mmd |
Adds configuration-winner example. |
build/docs/Utilities/Mermaid.cs |
Generates the new examples. |
build/common/Utilities/Extensions.cs |
Supports linked-worktree roots. |
.github/workflows/docs.yml |
Enforces review records in CI. |
.github/PULL_REQUEST_TEMPLATE.md |
Adds the review checklist item. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@coderabbitai full review Please review current head |
✅ Action performedFull review finished. |
|
@coderabbitai review Please review current head |
✅ Action performedReview finished.
|
|
Marked ready for review after validating current head
Copilot's request for domain-owner validation of the authored algorithm descriptions remains part of the normal human review. The PR closes #5300, assigned to milestone 7.0.x. |
83a9764 to
ce9f9e4
Compare
|
Rebased onto latest The four logical PR commits are preserved. Range-diff shows unchanged patches except removal of one extra blank line at EOF in the checker test file. Ancestry, whitespace, and worktree checks pass. Validation: 13 checker tests passed; seven algorithm review records verified; CI and hosted review are running on the rebased head; the previous green results apply to the pre-rebase head. |
|
|
Rebased head
No additional source changes, CI cancellations, or pushes were needed. The existing workflow/platform warnings and dependency scorecard advisories are non-blocking; CodeRabbit's generic docstring coverage advisory remains outside the repository's required gates. Copilot's request for human verification of the authored algorithm semantics remains part of normal review. The PR remains ready for review, closes #5300 in milestone 7.0.x, and has not been merged. Pausing the follow-up monitor now that the current-head checks and requested bot reviews are complete. |




















Description
Closes #5300.
Explain the current version-calculation pipeline with six authored Mermaid flowcharts covering strategy candidates, branch inheritance, increments, selection/counting sources, Mainline, and deployment modes. Add navigation, a table of contents, and eleven test-generated histories, including nine new worked examples backed by ten cases that assert versions and source metadata.
Require an explicit section review when mapped calculation sources change. Add a section manifest, a read-only checker with reviewed acknowledgements, contributor guidance, and CI integration. Fix Mermaid DOM initialization, linked-worktree root detection, and dark-theme diagram contrast; remove the unused legacy calculation diagram.
Validation
origin/mainatfe248d7765f280749a2bc97cff17eeb22c19f92c; current PR head isce9f9e4f270ae47b2db2b060213e5960271dae2f. Fresh local documentation validation passed (58 passed, 0 failed, 0 skipped); all 26 generated sources matched and all 32 Mermaid diagrams validated. Fresh CI and hosted reviews for this rebased head passed: Actions run 38164210299 completed successfully on attempt 1; Sonar reports zero new issues and no annotations; CodeRabbit covered this exact head with no actionable comments; Copilot reports zero open findings. All inline threads are resolved.83a9764f1bcfa9ee6533616a53f610555c889003, including the platform/backend test matrix, packaging, artifact/Docker checks, documentation, formatting, and CodeQL: run 37967168231.83a9764f1: Sonar passed with zero new issues and no annotations; CodeRabbit completed with no actionable comments; Copilot reported zero open findings. Its fixture-parallelism finding was fixed and resolved.The algorithm flowcharts remain manually authored. The source checker enforces review, not semantic correctness; the generated histories provide representative executable checkpoints.
Summary by CodeRabbit