Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitVersion.MsBuild.props #3887

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Update GitVersion.MsBuild.props #3887

merged 1 commit into from
Jan 28, 2024

Conversation

frg2089
Copy link
Contributor

@frg2089 frg2089 commented Jan 27, 2024 •
edited
Loading

Description

Add quote for outputfile.

Related Issue

Close #3888

Motivation and Context

Fixed Unhandled exception. GitVersion.WarningException: Could not parse command line parameter
It has been throwed when the path has space.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@frg2089 frg2089 marked this pull request as ready for review January 27, 2024 05:09
@asbjornu asbjornu merged commit 27c86e6 into GitTools:main Jan 28, 2024
134 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 28, 2024

Thank you @frg2089 for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] MSB3073 when outputfile path has space.
2 participants
@frg2089 @asbjornu