Skip to content

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Jan 22, 2024

Description

Create TrunkBasedVersionStrategy implementation and replace the version mode Mainline in 6.x.

Motivation and Context

For more detail please see the following ADR:

Next steps are:

  • Create TrunkBasedVersionStrategy implementation (done)
  • Create integration tests for TrunkBasedVersionStrategy (I skip this because of the limit time of reviewer)
  • Remove Mainline mode <<-- Part of this PR
  • Replace VersioningMode with DeploymentMode (pending)
  • Add new property with name strategy (type VersioningStrategies) to the configuration root level (pending)
  • Create documentation for TrunkBased workflow and add breaking changes notes (pending)

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic
Copy link
Member

@HHobeck is it ready for review?

@HHobeck
Copy link
Contributor Author

HHobeck commented Jan 22, 2024

@HHobeck is it ready for review?

Yes it is. Thank you for taking the time.

@arturcic
Copy link
Member

@HHobeck will you also update the docs according to the changes you made in this PR? Or maybe you add an additional step to update the docs to reflect the changes that you make?

@HHobeck
Copy link
Contributor Author

HHobeck commented Jan 22, 2024

I would say to finalize the feature and document it at the end. If you not mind

@arturcic
Copy link
Member

Then add to the Description of the Next Steps so we do not forget

@arturcic
Copy link
Member

I'd say it looks good to me, there is a small adjustment there, I would also want @asbjornu to have a look

@arturcic arturcic requested a review from asbjornu January 22, 2024 17:42
@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-II branch from 5840717 to 62b229e Compare January 22, 2024 18:54
@arturcic arturcic self-requested a review January 22, 2024 19:15

[Test]
[Ignore("Support of multiple tunks are not implemented at the moment.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is support for multiple trunks something you think can be added back before v6 goes final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I find the time because I see this feature as not so important. But anyway I think we should create a feature ticket for this.

@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-II branch from 46e7656 to b6fa0ac Compare January 23, 2024 11:04
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Co-authored-by: Asbjørn Ulsberg <asbjorn@ulsberg.no>
@arturcic
Copy link
Member

Hey @asbjornu if all the changes look good to you please merge the PR, and @HHobeck can move to the next step

@asbjornu asbjornu merged commit 6ae42cb into GitTools:main Jan 23, 2024
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you @HHobeck for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants