-
Notifications
You must be signed in to change notification settings - Fork 658
Replace the version mode Mainline in 6.x (Part II) #3879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the version mode Mainline in 6.x (Part II) #3879
Conversation
@HHobeck is it ready for review? |
Yes it is. Thank you for taking the time. |
@HHobeck will you also update the docs according to the changes you made in this PR? Or maybe you add an additional step to update the docs to reflect the changes that you make? |
I would say to finalize the feature and document it at the end. If you not mind |
Then add to the Description of the Next Steps so we do not forget |
src/GitVersion.Core/VersionCalculation/TrunkBased/TrunkBasedCommit.cs
Outdated
Show resolved
Hide resolved
I'd say it looks good to me, there is a small adjustment there, I would also want @asbjornu to have a look |
5840717
to
62b229e
Compare
...ests/Configuration/ConfigurationProviderTests.CanWriteOutEffectiveConfiguration.approved.txt
Show resolved
Hide resolved
|
||
[Test] | ||
[Ignore("Support of multiple tunks are not implemented at the moment.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is support for multiple trunks something you think can be added back before v6 goes final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I find the time because I see this feature as not so important. But anyway I think we should create a feature ticket for this.
...Version.Core/VersionCalculation/TrunkBased/NonTrunk/CommitOnNonTrunkWithPreReleaseTagBase.cs
Outdated
Show resolved
Hide resolved
…Fix unit test and uses the TrunkBased workflow implementation.
46e7656
to
b6fa0ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Co-authored-by: Asbjørn Ulsberg <asbjorn@ulsberg.no>
Thank you @HHobeck for your contribution! |
Description
Create TrunkBasedVersionStrategy implementation and replace the version mode Mainline in 6.x.
Motivation and Context
For more detail please see the following ADR:
Next steps are:
How Has This Been Tested?
Checklist: