Skip to content

Conversation

@arturcic
Copy link
Member

This PR adds 2 ways of parsing the semver string into SemanticVersion object - Loose - the old way we used so far, and Strict using the regex from https://semver.org.

Updated the tests to use the strict mode by default.

@arturcic arturcic requested a review from asbjornu May 30, 2022 07:48
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a little nit on the documentation.

@arturcic arturcic force-pushed the feature/strict-semver branch from 6abe670 to 90691a3 Compare May 31, 2022 07:14
@arturcic arturcic added this to the 6.x milestone May 31, 2022
@arturcic arturcic merged commit 0c4010c into GitTools:main May 31, 2022
@arturcic arturcic deleted the feature/strict-semver branch May 31, 2022 07:46
@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

Thank you @arturcic for your contribution!

@arturcic arturcic modified the milestones: 6.x, 6.0.0-alpha.1 Dec 22, 2022
@arturcic
Copy link
Member Author

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants