-
Notifications
You must be signed in to change notification settings - Fork 664
Ensure IEquatable takes nullable type #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
asbjornu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide a bit more context and information regarding this change? I hoped we would get fewer ? in the codebase going forward, not more?
|
I just assumed that as we were doing null checks in the equals, it was better to explicitly allow nulls but I understand your point. We can probably close the PR. |
|
Ok, I see. I suppose it's difficult to ensure these types aren't |
|
At this point yes. I assume/hope it will be easier after a couple of null-check iterations :) |
|
Indeed, let's merge this then. Can you please rebase and resolve conflicts? |
|
@asbjornu Done. |
|
Thank you @Evangelink for your contribution! |
|
🎉 This issue has been resolved in version 5.7.0 🎉 Your GitReleaseManager bot 📦🚀 |
Ensure that
IEquatable<T>targets nullable type and update related implementation.Related Issue
Follow-up of #2765