Ensure IEquatable takes nullable type #2781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
reviewed
Jul 27, 2021
|
I just assumed that as we were doing null checks in the equals, it was better to explicitly allow nulls but I understand your point. We can probably close the PR. |
|
Ok, I see. I suppose it's difficult to ensure these types aren't |
|
At this point yes. I assume/hope it will be easier after a couple of null-check iterations :) |
|
Indeed, let's merge this then. Can you please rebase and resolve conflicts? |
|
@asbjornu Done. |
asbjornu
approved these changes
Jul 31, 2021
|
Thank you @Evangelink for your contribution! |
|
🎉 This issue has been resolved in version 5.7.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
IEquatable<T>targets nullable type and update related implementation.Related Issue
Follow-up of #2765