Skip to content

Conversation

carlwoodhouse
Copy link
Contributor

@carlwoodhouse carlwoodhouse commented Apr 8, 2021

Description

As suggested in #2201 this fix uses the untrimmed branchname if a trim of the namespace prefix has resulted in an empty tag name, for branches with non namespaces eg 'somebranch" (#2201 (comment))

Related Issue

Resolves #2201

Motivation and Context

To allow prerelease tags for branches which aren't namespaced

How Has This Been Tested?

via a new unit test for the scenario(s), old ones are already covered.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asbjornu asbjornu merged commit d4920b2 into GitTools:main Apr 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2021

Thank you @carlwoodhouse for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Tag: useBranchName isn't working in some cases

2 participants