Move LibGit2Sharp implementation to separate lib #2525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
force-pushed
the
feature/libgit2sharp-separate-implementation
branch
from
c765cd5 to
d2b32cb
Compare
Member
Author
|
@asbjornu do you mind reviewing it? |
Member
Author
|
@asbjornu thank you for valuable feedback. The reason I kept it as in original (without too many changes of the code) is because I wanted in this PR to just replace the Classes with Interfaces and move to a separate lib project. If you do not mind I will address all the suggestions/ reviews as part of a different PR - improving the code, and keep this PR like this. Want to keep the scope of the PR moving the code out of the core. |
This was referenced Jan 11, 2021
Member
Author
|
added #2530 as an issue to continue the work |
|
🎉 This issue has been resolved in version 5.6.4 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2515