-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git version calculating wrong version when building a tag #2413
Git version calculating wrong version when building a tag #2413
Conversation
…f tags on the current commit
This is great! But there's something odd going on with the Docker tests. Can you please look into that?
|
I have no clue how to run the docker tests locally and debug them. |
Can you provide some guidance, @arturcic? |
Can you please rebase on the |
…f tags on the current commit
…g' of https://github.com/gerwinjansen/GitVersion into GitVersion-calculating-wrong-version-when-building-a-tag
@asbjornu: build is succesful (without any changes from my side). Can this PR be completed now? |
Excellent, thank you so much for your contribution @gerwinjansen! 🙏 |
Note: this PR is on top of #2411, that's why you see the changes again.
Description
TaggedCommitVersionStrategy will try to return the tags on the current commit. If there are none, it will returns the tags from the history.
Related Issue
Fixes #2074 GitVersion calculating wrong version when building a tag
How Has This Been Tested?
See steps to reproduce in my comments of the related ticket.
Checklist: