Added support for project type Microsoft.NET.Sdk.WindowsDesktop. #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
approved these changes
Jul 29, 2020
Member
|
@olivegamestudio thank you for your contributions 👍 |
|
I'm using GitVersion since a few days and ran into this issue today. Since the fix was added to the 5.5.0 milestone, when does it get released? |
Member
|
🎉 This issue has been resolved in version 5.5.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a check so that WindowsDesktop projects can be accepted. They are in the same format as the Microsoft.NET.Sdk.
I've added a unit test to match the existing ones as well.