[Bug] Inconsistency between GitVersion.MsBuild and GitVersion.Tool

[vhatsura]

Describe the bug
GitVersion.Tool sets NuGetVersionV2 as Version attribute in project file, however, GitVersion.MsBuild uses FullSemVer.

Expected Behavior

GitVersion.MsBuild should use NuGetVersionV2 as Version attribute in project file.

Actual Behavior

FullSemVer is used as the value for the Version attribute in the project file.

Possible Fix

Change a value in targets to $(GitVersion_NuGetVersionV2)

Steps to Reproduce

Context

It prevents from setting proper version for NuGet package with padded prerelease tag. As a workaround, it's possible to disable UseFullSemVerForNuGet.

Your Environment

• Version Used: 5.6.11

[asbjornu]

I agree it should be consistent, but I'm not sure whether GitVersion.Tool should start using FullSemVer or GitVersion.MsBuild should start using NuGetVersionV2. But one of them should probably change to the other. Thoughts, @arturcic?

[arturcic]

I agree that we need to make it consistent, but I would go for $(GitVersion_NuGetVersion) for both cases.
@vhatsura are you in a position to make this change and submit a PR?

[vhatsura]

I agree that we need to make it consistent, but I would go for $(GitVersion_NuGetVersion) for both cases.

@vhatsura are you in a position to make this change and submit a PR?

Yeap, I’m open to implement such changes.

[github-actions]

🎉 This issue has been resolved in version 5.8.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀