(#113) Return all issues that have errors #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are issues that contain invalid issues, rather than throw a single exception for the first problem, throw an exception that contains information about all the problematic issues. This saves the end user from having to run GRM multiple times, fixing one issue at a time.
We are now throwing a specific exception, rather than an InvalidOperationException. Also, added new tests to assert the correct number of errors returned in the new exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are issues that contain invalid issues, rather than throw
a single exception for the first problem, throw an exception that
contains information about all the problematic issues. This saves the
end user from having to run GRM multiple times, fixing one issue at
a time.
Related Issue
Fixes #113
Motivation and Context
This makes it much easier for working through problematic issues, and prevents the need to run GRM multiple times.
How Has This Been Tested?
New unit tests have been added, and existing tests have been exercised and validated.
Screenshots (if appropriate):
Checklist: