Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect exception logging #203

Closed
wants to merge 1 commit into from
Closed

Fix incorrect exception logging #203

wants to merge 1 commit into from

Conversation

SimonCropp
Copy link
Contributor

we r logging the the parent exception instead of the inner exception

@gep13 gep13 added this to the 0.10.3 milestone Jan 25, 2020
@gep13 gep13 added the Bug label Jan 25, 2020
@gep13 gep13 changed the base branch from develop to hotfix/0.10.3 January 25, 2020 08:48
@gep13 gep13 changed the base branch from hotfix/0.10.3 to develop January 25, 2020 08:49
@gep13 gep13 changed the title fix incorrect exception logging Fix incorrect exception logging Jan 25, 2020
@gep13
Copy link
Member

gep13 commented Jan 25, 2020

@SimonCropp that is a great catch, thanks for spotting that. I have cherry-picked this commit into a hotfix branch, so that I can get this released straight away. As a result, I am going to close this PR.

@gep13 gep13 closed this Jan 25, 2020
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.10.3 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@SimonCropp
Copy link
Contributor Author

@gep13 thanks :)

@SimonCropp SimonCropp deleted the loggingWrongException branch January 26, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants