Skip to content

Conversation

@amaelftah
Copy link
Contributor

reference
#36 #50 #176 #229

Notes :-

  • bibucket returns uuids so i had to add the migrations to change tables that contains provider and provider_id columns

  • without bitbucket token sent as a request header , it won't retrieve the current user private repos that he owns so i had to change the request helper method

  • i added the refresh_token column , cause bitbucket token expires after 1 hour as mentioned in the documentation , also i provided a screenshot of how the object will look like
    refreshToken

  • in handleProviderCallback the user from socialite must be updated , to update his refresh_token and token

  • some of the methods uses version 1.0 of the api , because these end points aren't supported in version 2.0

  • in the readCollaborators if the repo owner is logged in and currently importing the repo into GitScrum the method will get all associated collaborators , otherwise , it won't get associated collaborators, and the reason for this as mentioned in the documentation priviliges , Only the repository owner, a team account administrator, or an account with administrative rights on the repository can make this call

screenshot from 2017-09-17 23-21-28

@renatomarinho
Copy link
Collaborator

Hi @Te7a-Houdini,

Thanks for you PR!
Please, send your contact mail to renato.marinho@s2move.com

Cheers,
Renato Marinho

@renatomarinho renatomarinho merged commit 587351a into GitScrum-Team:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants