Flag to delete subcollection #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Will update the readme for new features |
nbransby
reviewed
Jul 17, 2020
src/common.ts
Outdated
Comment on lines
21
to
26
| export function isSubCollection(collection: string): boolean { | ||
| const filteredCollections = collection.split('/').filter(c => c.length > 0); | ||
| const numCollections = filteredCollections.length; | ||
| // Return false is equal to 1 or an even number | ||
| return numCollections !== 1 && numCollections % 2 === 1; | ||
| } |
Member
There was a problem hiding this comment.
Do we need to restrict it to subcollections now? As we have an explicit flag we could allow it to work on any collection?
Collaborator
Author
There was a problem hiding this comment.
Not really. The explicit flag should be enough
nbransby
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5, added flag to delete all sub-collections. This made the foreign key optional. Added error checking so that either the flag has to be true or a foreign key provided. Only sub-collections can be deleted. Top collections cannot be.