Skip to content

Fix: Clean up logging #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbransby merged 2 commits into from
Aug 25, 2020
Merged

Fix: Clean up logging #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c39df6
fix: Remove redundant logging
michaelprichardson Aug 24, 2020
254c9fe
fix: Remove redundant logging
michaelprichardson Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ export function replaceReferencesWith(
? fields.source[cleanedIndex]
: fields[cleanedIndex];
if (field) {
console.log(
`integrify: Detected dynamic reference, replacing [${match}] with [${field}]`
);
// console.log(
// `integrify: Detected dynamic reference, replacing [${match}] with [${field}]`
// );
targetCollection = targetCollection.replace(match, field);
} else {
throw new Error(`integrify: Missing dynamic reference: [${match}]`);
Expand Down
14 changes: 7 additions & 7 deletions src/rules/deleteReferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ export function integrifyDeleteReferences(
): CloudFunction<QueryDocumentSnapshot> {
const functions = config.config.functions;

rule.targets.forEach(target =>
console.log(
`integrify: Creating function to delete all references to source [${rule.source.collection}] from [${target.collection}] linked by key [${target.foreignKey}]`
)
);
// rule.targets.forEach(target =>
// console.log(
// `integrify: Creating function to delete all references to source [${rule.source.collection}] from [${target.collection}] linked by key [${target.foreignKey}]`
// )
// );

const { hasPrimaryKey, primaryKey } = getPrimaryKey(rule.source.collection);
if (!hasPrimaryKey) {
Expand All @@ -64,7 +64,7 @@ export function integrifyDeleteReferences(
// Call "pre" hook if defined
if (rule.hooks && rule.hooks.pre) {
await rule.hooks.pre(snap, context);
console.log(`integrify: Running pre-hook: ${rule.hooks.pre}`);
// console.log(`integrify: Running pre-hook: ${rule.hooks.pre}`);
}

// Loop over each target
Expand Down Expand Up @@ -132,7 +132,7 @@ export function integrifyDeleteReferences(
// Call "post" hook if defined
if (rule.hooks && rule.hooks.post) {
await rule.hooks.post(snap, context);
console.log(`integrify: Running post-hook: ${rule.hooks.post}`);
// console.log(`integrify: Running post-hook: ${rule.hooks.post}`);
}
});
}
22 changes: 11 additions & 11 deletions src/rules/replicateAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,16 @@ export function integrifyReplicateAttributes(
): CloudFunction<Change<QueryDocumentSnapshot>> {
const functions = config.config.functions;

console.log(
`integrify: Creating function to replicate source collection [${rule.source.collection}]`
);
rule.targets.forEach(target => {
Object.keys(target.attributeMapping).forEach(sourceAttribute => {
console.log(
`integrify: Replicating [${rule.source.collection}].[${sourceAttribute}] => [${target.collection}].[${target.attributeMapping[sourceAttribute]}]`
);
});
});
// console.log(
// `integrify: Creating function to replicate source collection [${rule.source.collection}]`
// );
// rule.targets.forEach(target => {
// Object.keys(target.attributeMapping).forEach(sourceAttribute => {
// console.log(
// `integrify: Replicating [${rule.source.collection}].[${sourceAttribute}] => [${target.collection}].[${target.attributeMapping[sourceAttribute]}]`
// );
// });
// });

const { hasPrimaryKey, primaryKey } = getPrimaryKey(rule.source.collection);
if (!hasPrimaryKey) {
Expand Down Expand Up @@ -78,7 +78,7 @@ export function integrifyReplicateAttributes(
// Call "pre" hook if defined
if (rule.hooks && rule.hooks.pre) {
await rule.hooks.pre(change, context);
console.log(`integrify: Running pre-hook: ${rule.hooks.pre}`);
// console.log(`integrify: Running pre-hook: ${rule.hooks.pre}`);
}

// Check if at least one of the attributes to be replicated was changed
Expand Down